etr2460 commented on a change in pull request #9120: Add feature flags to
control query sharing, KV exposure
URL:
https://github.com/apache/incubator-superset/pull/9120#discussion_r380822437
##########
File path: tests/core_tests.py
##########
@@ -497,6 +504,9 @@ def test_shortner(self):
resp = self.client.post("/r/shortner/", data=dict(data=data))
assert re.search(r"\/r\/[0-9]+", resp.data.decode("utf-8"))
+ @skipUnless(
Review comment:
In this case it would be, since the feature flag only removes functionality
and doesn't add anything different. that said, I think we should be able to
test both sides of the feature flag here, do you know how to do this @dpgaspar ?
Maybe mocking the feature flag checking function?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
