[GitHub] [incubator-superset] etr2460 opened a new pull request #9162: [SIP-36] Migrate Link.jsx to Link.tsx

[GitBox]

etr2460 opened a new pull request #9162: [SIP-36] Migrate Link.jsx to Link.tsx
URL: https://github.com/apache/incubator-superset/pull/9162
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [x] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   This is an example PR for migrating a React component from JSX to TSX. I 
performed the following steps:
   1. Rename the component file from `Link.jsx` => `Link.tsx`
   1. Install typedefs for imported libraries if required (ex. `npm install 
@types/react-bootstrap`)
   1. Replace the `propTypes` const with a `type Props` definition
   1. Move default props into the default arguments within the React component
   1. Resolve any type errors that may have been exposed by the migration
   1. Attach before/after screenshots to the PR to ensure the component 
functionality remains the same
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   <img width="308" alt="Screen Shot 2020-02-18 at 10 20 51 AM" 
src="https://user-images.githubusercontent.com/7409244/74765412-60914200-5238-11ea-9f25-37ca0c4d3db6.png";>
   
   After:
   <img width="301" alt="Screen Shot 2020-02-18 at 10 15 36 AM" 
src="https://user-images.githubusercontent.com/7409244/74765420-6424c900-5238-11ea-8990-b121264b283e.png";>
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   CI and unit tests, confirm the Link component in SQL Lab renders as expected
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: #9101
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   to: @graceguo-supercat @nytai @rusackas @kristw 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org