nytai opened a new pull request #9172: [SIP-36] deprecate tslint and configure eslint for typescript URL: https://github.com/apache/incubator-superset/pull/9172 ### CATEGORY Choose one - [ ] Bug Fix - [ ] Enhancement (new features, refinement) - [x] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> This PR deprecates tslint and configures eslint for typescript files. Using `@airbnb/nimbus` would be preferable as a long term goal, however that library is poorly documented and I had trouble getting it to work with our current setup. I left the WIP on a branch https://github.com/preset-io/incubator-superset/tree/tai/eslint-ts if anyone more familiar with integratin nimbus into existing projects would like to pick it up. For now this gets rid of tslint (and it's overly strict rules) which should make it easier to transition to typescript. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TEST PLAN <!--- What steps should be taken to verify the changes --> - [x] linting works ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: Fixes https://github.com/apache/incubator-superset/issues/8865 - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS @etr2460 @suddjian @rusackas
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
