etr2460 opened a new pull request #9180: [SIP-36] Migrate setupApp.js to setupApp.ts URL: https://github.com/apache/incubator-superset/pull/9180 ### CATEGORY Choose one - [ ] Bug Fix - [x] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY This is an example PR for migrating a JS file to TS. I performed the following steps: 1. Rename the file from `setupApp.js` => `setupApp.ts` 1. Install typedefs for imported libraries (ex `npm install @types/jquery` or add `// @ts-ignore` if no valid typedefs exist 1. Type function arguments to their expected values 1. Address all eslint warnings and errors ### TEST PLAN CI, confirm that previous behavior is still correct. In this case, check changing locales still works and that checkboxes work in CRUD Views ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: #9101 - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS to: @nytai @graceguo-supercat @kristw @rusackas
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
