[GitHub] [incubator-superset] rusackas opened a new pull request #9183: forcing fixed width fonts on ace editor (fixes #9095)

Thu, 20 Feb 2020 17:12:22 -0800 

rusackas opened a new pull request #9183: forcing fixed width fonts on ace 
editor (fixes #9095)
URL: https://github.com/apache/incubator-superset/pull/9183
 
 
   ### CATEGORY
   
   Choose one
   
   - [X] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Adds some CSS to force fixed width fonts onto the ace editor (sql editor) so 
Safari knows where to place the cursor. 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   before ("SELECT" is kerned/tracked too far, cursor is too far inward
   <img width="199" alt="Screen Shot 2020-02-20 at 5 07 23 PM" 
src="https://user-images.githubusercontent.com/812905/74994712-a3ebdc00-5403-11ea-8f13-466b96b28441.png";>
   
   
   after ("SELECT" is fixed-width, cursor is at the end of the text as expected)
   <img width="322" alt="Screen Shot 2020-02-20 at 5 06 55 PM" 
src="https://user-images.githubusercontent.com/812905/74994719-a77f6300-5403-11ea-8fa4-c1d410d66df8.png";>
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: Fixes #9095
   - [x] Changes UI (barely... minor font tracking)
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to