etr2460 opened a new pull request #9191: Make JSX Menu links open in new tab URL: https://github.com/apache/incubator-superset/pull/9191 ### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY When the new React navbar was built, the functionality of bug reporting and documentation links opening in a new tab wasn't ported over. This fixes it. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF looks like this before and after:  ### TEST PLAN Set the config value for the DOCUMENTATION_URL, click the link, see it open in another tab See other links open in the current tab as before ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS to: @willbarrett @graceguo-supercat @john-bodley
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
