graceguo-supercat commented on a change in pull request #9188: [dashboard] fix 
filter_scopes when copy dashboard with duplicate_slices
URL: 
https://github.com/apache/incubator-superset/pull/9188#discussion_r382933304
 
 

 ##########
 File path: superset/views/core.py
 ##########
 @@ -1195,6 +1195,20 @@ def copy_dash(self, dashboard_id):
                     old_id = "{}".format(value.get("meta").get("chartId"))
                     new_id = int(old_to_new_sliceids[old_id])
                     value["meta"]["chartId"] = new_id
+
+            if "filter_scopes" in data:
 
 Review comment:
   added a util function to clean up.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to