john-bodley commented on a change in pull request #8699: [SIP-29] Add support
for row-level security
URL:
https://github.com/apache/incubator-superset/pull/8699#discussion_r384746386
##########
File path: superset/security/manager.py
##########
@@ -891,3 +892,48 @@ def assert_viz_permission(self, viz: "BaseViz") -> None:
"""
self.assert_datasource_permission(viz.datasource)
+
+ def get_rls_filters(self, table: "BaseDatasource"):
+ """
+ Retrieves the appropriate row level security filters for the current
user and the passed table.
+
+ :param table: The table to check against
+ :returns: A list of filters.
+ """
+ if hasattr(g, "user") and hasattr(g.user, "id"):
+ from superset import db
+ from superset.connectors.sqla.models import (
+ RLSFilterRoles,
+ RowLevelSecurityFilter,
+ )
+
+ user_roles = (
+ db.session.query(assoc_user_role.c.role_id)
+ .filter(assoc_user_role.c.user_id == g.user.id)
+ .subquery()
+ )
+ filter_roles = (
+ db.session.query(RLSFilterRoles.c.id)
+ .filter(RLSFilterRoles.c.role_id.in_(user_roles))
+ .subquery()
+ )
+ query = (
+ db.session.query(
+ RowLevelSecurityFilter.id, RowLevelSecurityFilter.clause
+ )
+ .filter(RowLevelSecurityFilter.table_id == table.id)
+ .filter(RowLevelSecurityFilter.id.in_(filter_roles))
+ )
+ return query.all()
+ return []
+
+ def get_rls_ids(self, table: "BaseDatasource") -> List[int]:
+ """
+ Retrieves the appropriate row level security filters IDs for the
current user and the passed table.
+
+ :param table: The table to check against
+ :returns: A list of IDs.
+ """
+ ids = [f.id for f in self.get_rls_filters(table)]
+ ids.sort() # Combinations rather than permutations
Review comment:
It seems these IDs are sorted to satisfy the cache consistency. Rather than
storing these as an ordered list why not return these as a set?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
