john-bodley commented on issue #9213: [fix] remove chart id from filter_scopes metadata if chart is not in dash anymore URL: https://github.com/apache/incubator-superset/pull/9213#issuecomment-591701669 @graceguo-supercat part of my confusion was the reuse of the `slice_id` local variable. For readability there may be merit in using a different variable name. This comment is non-blocking.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
