john-bodley commented on a change in pull request #8867: Make schema name for
the CTA queries and limit configurable
URL:
https://github.com/apache/incubator-superset/pull/8867#discussion_r384940868
##########
File path: superset/sql_parse.py
##########
@@ -151,20 +151,28 @@ def __process_tokenlist(self, token_list: TokenList):
self._alias_names.add(token_list.tokens[0].value)
self.__extract_from_token(token_list)
- def as_create_table(self, table_name: str, overwrite: bool = False) -> str:
+ def as_create_table(
+ self,
+ table_name: str,
+ schema_name: Optional[str] = None,
+ overwrite: bool = False,
+ ) -> str:
"""Reformats the query into the create table as query.
Works only for the single select SQL statements, in all other cases
the sql query is not modified.
- :param table_name: Table that will contain the results of the query
execution
+ :param table_name: table that will contain the results of the query
execution
+ :param schema_name: schema name for the target table
:param overwrite: table_name will be dropped if true
:return: Create table as query
"""
exec_sql = ""
sql = self.stripped()
+ # TODO(bkyryliuk): quote full_table_name
+ full_table_name = f"{schema_name}.{table_name}" if schema_name else
table_name
Review comment:
Shouldn’t we address the TODO? Note the quoter needs to be dialect specific.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
