craig-rueda commented on a change in pull request #9218: Prevent database
connections to sqlite
URL:
https://github.com/apache/incubator-superset/pull/9218#discussion_r385916646
##########
File path: superset/views/core.py
##########
@@ -1314,6 +1318,8 @@ def testconn(self):
db_name = request.json.get("name")
uri = request.json.get("uri")
try:
+ if app.config.get("PREVENT_UNSAFE_DB_CONNECTIONS"):
Review comment:
Change `app.config.get("PREVENT_UNSAFE_DB_CONNECTIONS")` ->
`app.config["PREVENT_UNSAFE_DB_CONNECTIONS"]` as all configs are required to
have defaults.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
