graceguo-supercat opened a new pull request #9224: refactor copy filter_scopes and add tests URL: https://github.com/apache/incubator-superset/pull/9224 ### CATEGORY Choose one - [ ] Bug Fix - [ ] Enhancement (new features, refinement) - [x] Refactor - [x] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY In #9213 I am trying to fix an issue urgently. But it turned out 3 places called a function in the similar pattern. I want to add a little refactor for the code, and add some test for this fix. ### TEST PLAN Added unit test. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: #9213 - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS @serenajiang @john-bodley
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
