villebro opened a new pull request #9240: fix: Oracle fetch_query and datetime conversion URL: https://github.com/apache/incubator-superset/pull/9240 ### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY The Oracle spec extended `PostgresBaseEngineSpec`, which didn't really make any sense, as Oracle has very little in common with Postgres. As `FixedOffsetTimezone` was added to `PostgresBaseEngineSpec` recently, data fetching was consequently broken, as it isn't needed for Oracle. Changes in this PR: - `OracleEngineSpec` now extends `BaseEngineSpec`. This fixes `fetch_data`. - Epoch (second and ms) expressions were implemented and tested to work - `DATETIME` expression was added + unit test ### TEST PLAN Test locally + CI ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: closes #9237 . The issue reported was actually already fixed, but it exposed the regression and shortcomings that are addressed here. - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
