[GitHub] [incubator-superset] graceguo-supercat opened a new pull request #9243: [log] Add dashboard_id param to explore_json request

Wed, 04 Mar 2020 19:48:26 -0800 

graceguo-supercat opened a new pull request #9243: [log] Add dashboard_id param 
to explore_json request
URL: https://github.com/apache/incubator-superset/pull/9243
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [x] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   whenever Superset run a query from dashboard or explore view, we will log a 
`explore_json` action. This is useful when we analysis traffic. But currently 
we can't tell the traffic is from dashboard request or explore view.
   
   This PR is to add `dashboard_id` parameter in the explore_json request which 
is triggered from all the dashboard interaction, like dashboard load, force 
refresh chart, periodical refresh etc. Our current log function can detect 
`dashboard_id` parameter and add it to the log entry.
   
   Note the `dashboard_id` is added to request parameter, it won't change 
`form_data`
   
   Before:
   <img width="1035" alt="Screen Shot 2020-03-04 at 7 35 27 PM" 
src="https://user-images.githubusercontent.com/27990562/75945900-6863ff80-5e50-11ea-943c-336a3639daad.png";>
   
   After:
   <img width="1030" alt="Screen Shot 2020-03-04 at 7 36 09 PM" 
src="https://user-images.githubusercontent.com/27990562/75945909-71ed6780-5e50-11ea-808a-39fd0c95251b.png";>
   
   
   ### TEST PLAN
   CI
   
   ### REVIEWERS
   @john-bodley @etr2460 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to