villebro commented on a change in pull request #9107: feat: add rolling window
support to 'Big Number with Trendline' viz
URL:
https://github.com/apache/incubator-superset/pull/9107#discussion_r389383605
##########
File path: superset/examples/birth_names.py
##########
@@ -144,14 +145,17 @@ def load_birth_names(only_metadata=False, force=False):
granularity_sqla="ds",
compare_lag="5",
compare_suffix="over 5Y",
+ metric=metric,
),
),
Slice(
slice_name="Genders",
viz_type="pie",
datasource_type="table",
datasource_id=tbl.id,
- params=get_slice_json(defaults, viz_type="pie",
groupby=["gender"]),
+ params=get_slice_json(
+ defaults, viz_type="pie", groupby=["gender"], metrics=metrics
Review comment:
During testing I noticed that the Gender chart wasn't rendering correctly:
As the pie chart wants the singular `metric`, you need to change
`metrics=metrics` to `metric=metric` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
