etr2460 commented on a change in pull request #9210: Add maximize and minimize
feature to charts
URL:
https://github.com/apache/incubator-superset/pull/9210#discussion_r389387977
##########
File path: superset-frontend/src/dashboard/stylesheets/components/chart.less
##########
@@ -148,3 +148,10 @@
.time-filter-tabs > .nav-tabs > li > a {
padding: 4px;
}
+
+.full-size-style {
+ position: fixed;
+ z-index: 1000;
+ left: 0px;
+ top: 0px;
+};
Review comment:
a couple nits:
- Name this `full-size`, we know it's applying styling because it's already
in css
- Use one of the z-index constants here if one of them works, or add a new
one for dashboard modals
https://github.com/apache/incubator-superset/blob/7d572d9e9621e6c469d6db0afe650e41fcf297b1/superset-frontend/stylesheets/less/variables.less#L106-L124
- `left` and `top` can just be `0` instead of `0px`
- Remove the semicolon and make sure there's a new line at the end of the
file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
