willbarrett commented on a change in pull request #9255: fix: change database 
save in DatasourceEditor
URL: 
https://github.com/apache/incubator-superset/pull/9255#discussion_r389803384
 
 

 ##########
 File path: tests/base_tests.py
 ##########
 @@ -268,7 +268,7 @@ def create_fake_db(self):
             cls=models.Database,
             criteria={"database_name": database_name},
             session=db.session,
-            sqlalchemy_uri="sqlite://test",
+            sqlalchemy_uri="sqlite:///:memory:",
 
 Review comment:
   👍 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to