ktmud opened a new pull request #9269: fix: upgrade legacy table chart to 
0.11.17
URL: https://github.com/apache/incubator-superset/pull/9269
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   
   ### SUMMARY
   
   https://github.com/apache/incubator-superset/pull/9234 introduced a bug in 
which the table chart throws errors when rerendering with different query 
results. It also lacks handling of null values in metrics and percent metrics.
   
   https://github.com/apache-superset/superset-ui-plugins/pull/392 fixed it. 
This PR bumps plugin dependency to enable this fix.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   N/A
   
   ### TEST PLAN
   
   A fresh install of Superset or `npm install` should already fixes the bug 
because we published a minor new version.
   
   To reproduce the bug, run `npm install 
@superset-ui/[email protected]`. Then go to any Table chart, 
either add or remove a new metric, rerun the query multiple times. Run any 
query with Table chart multiple times, it should not thrown a JS error like 
this:
   
   
![image](https://user-images.githubusercontent.com/335541/76267496-3bd12e80-6228-11ea-89d7-7b136c942f87.png)
   
   It should not throw this error after the fix.
   
   ### ADDITIONAL INFORMATION
   
   None
   
   ### REVIEWERS
   
   @kristw @etr2460 @graceguo-supercat 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to