graceguo-supercat opened a new pull request #9271: [fix] copy filter_scopes with duplicate charts URL: https://github.com/apache/incubator-superset/pull/9271 ### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY in code refactor PR #9224, it introduced a bug: https://github.com/apache/incubator-superset/blob/7a91498cf1a9e56d4b3d7b3805076137525ea277/superset/views/core.py#L1293 here we should use old slice's id as key instead of `sid` which is new or copied slice's id ### TEST PLAN fixed unit test. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: #9224 ### REVIEWERS @serenajiang @john-bodley
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
