craig-rueda commented on a change in pull request #8947: [thumbnails]
thumbnails for dashboards and charts
URL:
https://github.com/apache/incubator-superset/pull/8947#discussion_r390490421
##########
File path: superset/models/slice.py
##########
@@ -321,3 +343,8 @@ def set_related_perm(mapper, connection, target):
sqla.event.listen(Slice, "after_insert", ChartUpdater.after_insert)
sqla.event.listen(Slice, "after_update", ChartUpdater.after_update)
sqla.event.listen(Slice, "after_delete", ChartUpdater.after_delete)
+
+# events for updating tags
+if is_feature_enabled("THUMBNAILS_SQLA_LISTENERS"):
Review comment:
Is there a way to drag this out of the model? I see this as debt that will
need to be paid down in the future, as models should themselves be as lean as
possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
