dpgaspar commented on a change in pull request #8947: [thumbnails] thumbnails
for dashboards and charts
URL:
https://github.com/apache/incubator-superset/pull/8947#discussion_r391051254
##########
File path: superset/models/dashboard.py
##########
@@ -184,6 +185,22 @@ def dashboard_link(self) -> Markup:
title = escape(self.dashboard_title or "<empty>")
return Markup(f'<a href="{self.url}">{title}</a>')
+ @property
+ def unique_value(self) -> str:
Review comment:
No problem, but, this is actually an MD5 Exa, `unique_value` is aiming for a
generic unique value digest. Maybe `unique_digest` or just `digest`, any ideas?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
