etr2460 commented on a change in pull request #9284: Reduce dashboard bootstrap payload URL: https://github.com/apache/incubator-superset/pull/9284#discussion_r391269184
########## File path: superset/connectors/base/models.py ########## @@ -27,6 +27,23 @@ from superset.models.slice import Slice from superset.utils import core as utils +METRIC_FORM_DATA_PARAMS = [ + "metric", + "timeseries_limit_metric", + "size", + "x", + "y", + "metric_2", +] Review comment: note that `percent_metrics` is referenced in the function below because it's an array of metrics and not an individual one. It looks like I missed secondary_metric though. I'll refactor so that those are included in a constant as well. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
