etr2460 commented on issue #9284: Reduce dashboard bootstrap payload URL: https://github.com/apache/incubator-superset/pull/9284#issuecomment-598458359 So I took a look to see what code on the frontend depends on various properties on the datasource. You can see all the places charts depend on the datasource here: https://github.com/apache-superset/superset-ui-plugins/search?p=1&q=datasource&unscoped_q=datasource From what I can see, the datasource is used primarily for two reasons: 1. To add special number formatting to a metric as in: https://github.com/apache-superset/superset-ui-plugins/blob/17a5f64312326e708a81bab4a45578fd181b2e1e/packages/superset-ui-legacy-preset-chart-big-number/src/BigNumber/transformProps.js#L88-L92 2. To format the name of a metric differently as in: https://github.com/apache-superset/superset-ui-plugins/blob/be604e24fd9c7ac715e448673c56bed40c5344ff/packages/superset-ui-legacy-plugin-chart-partition/src/transformProps.js#L43 All of the instances i've tested haven't broken any charts entirely, so I think the main source of regressions would be formatting regressions (e.g. rendering 0.03 instead of 3% or "metric_name_not_pretty" instead of "Pretty Metric Name"). I think that we could merge this now and deploy internally, being ready to revert fast if needed or patch with any minor issues that show up. Alternatively I could put this behind a feature flag and only enable it in our deployment to start if we thought that was safer. Up to @john-bodley and @villebro (and anyone else who has input)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
