villebro commented on issue #9282: [WIP] disable quotes for Kylin URL: https://github.com/apache/incubator-superset/pull/9282#issuecomment-599258414 Thanks for the additional context, @mgulaydin . Having given this some additional thought, I think the right place to tackle this is in `kylinpy`. If your case is representative of a typical Kylin installation, the connector should not be adding quotes that are not supported by the dialect. Therefore we should probably defer this discussion to the [kylinpy GitHub page](https://github.com/Kyligence/kylinpy). If there is any fine tuning that needs to take place in Superset, we can definitely accommodate for that in the Kylin spec. Feel free to tag me in issues/PRs in the kylinpy repo. I'll close this WIP PR for now., but once the necessary changes have been made to `kylinpy`, we can open up a new PR if there are any outstanding changes that need to be made to the Kylin spec.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
