etr2460 opened a new pull request #9313: Revert "feat: add rolling window support to 'Big Number with Trendline' viz" URL: https://github.com/apache/incubator-superset/pull/9313 Reverts apache/incubator-superset#9107 This change broke rendering of NULL values in the Big Number with Trendline viz. NULL values now render as 0, which is misleading. I'm reverting as this is a data accuracy bug and is fairly high priority. Repro steps: - Run a query like this in SQL Lab: ``` SELECT * FROM ( VALUES ('2020-02-29', 4), ('2020-03-01', 1), ('2020-03-02', NULL), ('2020-03-03', 2), ('2020-03-04', 3)) AS t (ds, value) ``` - Explore it and select the big number with trend line viz - See 0 instead of NULL in the trendline <img width="1920" alt="Screen Shot 2020-03-16 at 1 47 37 PM" src="https://user-images.githubusercontent.com/7409244/76799019-f8c60c80-678d-11ea-8cf0-04943dd65b7b.png";>
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/7409244/76799019-f8c60c80-678d-11ea-8cf0-04943dd65b7b.png"](https://user-images.githubusercontent.com/7409244/76799019-f8c60c80-678d-11ea-8cf0-04943dd65b7b.png"){kind=link}