rusackas edited a comment on issue #9187: [SIP-38] Visualization plugin refactoring URL: https://github.com/apache/incubator-superset/issues/9187#issuecomment-600919833 @kristw Thanks for your thoughts on this > Generating MainPreset.js from the configuration file could be another solution as well. This is essentially what I'm trying to take a step toward. My understanding is that to do that, you'd have to load in an array of plugins/paths from the config (or some state driven by a future UI, even), and then you could then dynamically load those packages and/or paths. This is what that other WiP PR is taking a stab at. > For clarification, if the bundle size is concerned, Superset is already lazy-loading the plugins via dynamic imports. Bundle size isn't the main concern here, so much as developer convenience. > how will dynamic import help with adding new plugins that are not listed in package.json from master? My thought (though admittedly half baked, since we're not at this stage yet) would be that people could have any number of plugins added to their local/deployed filesystem, and dynamic loading would let them add the point to the module or just the file path of that plugin, once loaded from the aforementioned config/state. That would all be done dynamically in MainPreset.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
