villebro commented on a change in pull request #9355: Cal heatmap controls
migration
URL:
https://github.com/apache/incubator-superset/pull/9355#discussion_r396908889
##########
File path: superset-frontend/src/explore/controlPanels/CalHeatmap.js
##########
@@ -35,21 +78,94 @@ export default {
expanded: true,
controlSetRows: [
['linear_color_scheme'],
- ['cell_size', 'cell_padding'],
- ['cell_radius', 'steps'],
- ['y_axis_format', 'x_axis_time_format'],
+ [
+ {
+ name: 'cell_size',
+ config: {
+ type: 'TextControl',
+ isInt: true,
+ default: 10,
+ validators: [v.integer],
+ renderTrigger: true,
+ label: t('Cell Size'),
+ description: t('The size of the square cell, in pixels'),
+ },
+ },
+ {
+ name: 'cell_padding',
+ config: {
+ type: 'TextControl',
+ isInt: true,
+ validators: [v.integer],
+ renderTrigger: true,
+ default: 2,
+ label: t('Cell Padding'),
+ description: t('The distance between cells, in pixels'),
+ },
+ },
+ ],
+ [
+ {
+ name: 'cell_radius',
+ config: {
+ type: 'TextControl',
+ isInt: true,
+ validators: [v.integer],
+ renderTrigger: true,
+ default: 0,
+ label: t('Cell Radius'),
+ description: t('The pixel radius'),
+ },
+ },
+ {
+ name: 'steps',
+ config: {
+ type: 'TextControl',
+ isInt: true,
+ validators: [v.integer],
+ renderTrigger: true,
+ default: 10,
+ label: t('Color Steps'),
+ description: t('The number color "steps"'),
+ },
+ },
+ ],
+ [
+ 'y_axis_format',
+ {
+ name: 'x_axis_time_format',
Review comment:
@runsackas I like the idea of doing a migration batch to clean up duplicate
controls. Let's hold off on the changes for now and put them in a google sheet
or similar so we can do one or two migrations when the control migration is
otherwise done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
