rusackas commented on issue #9356: linting some LESS URL: https://github.com/apache/incubator-superset/pull/9356#issuecomment-603538976 > I saw this too and I was wondering if `stylesheets/fonts/FiraCode/` belonged into a `vendors/` or `external/` folder instead of `stylesheets/` > > It depends on whether we're taking ownership of the code/assets and are likely to alter the source, or whether we're more likely to leave it untouched or upgrade in place. I originally thought to put it into /stylesheets because there IS a stylesheet in there that's referenced. Putting that part in vendors/external didn't make so much sense to me since we have/will make edits to the file(s). How about in another PR, I move the binaries to some sort of vendor assets folder, and adjust the paths in the fonts' stylesheets? If you'd rather I shoehorn that in here, I certainly can :)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
