dpgaspar commented on a change in pull request #9376: Add
CUSTOM_TEMPLATE_PROCESSOR config
URL:
https://github.com/apache/incubator-superset/pull/9376#discussion_r398314274
##########
File path: tests/core_tests.py
##########
@@ -668,6 +668,80 @@ def test_templated_sql_json(self):
data = self.run_sql(sql, "fdaklj3ws")
self.assertEqual(data["data"][0]["test"], "2017-01-01T00:00:00")
+ @mock.patch("tests.superset_test_config.datetime")
+ def test_custom_process_template(self, mock_dt) -> None:
+ """Test macro defined in custom template processor works."""
+ mock_dt.utcnow = mock.Mock(return_value=datetime.datetime(1970, 1, 1))
+ db = mock.Mock()
+ db.backend = "presto"
+ tp = jinja_context.get_template_processor(database=db)
+
+ sql = "SELECT '$DATE()'"
+ rendered = tp.process_template(sql)
+ self.assertEqual("SELECT '{}'".format("1970-01-01"), rendered)
+
Review comment:
It would be nice to have a test with a different backend and check that the
macro is ignored
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
