kristw commented on a change in pull request #9333:  build: use manifest hooks 
for dev server proxy and fix hot reload for charts
URL: 
https://github.com/apache/incubator-superset/pull/9333#discussion_r398811952
 
 

 ##########
 File path: superset-frontend/src/dashboard/components/gridComponents/Chart.jsx
 ##########
 @@ -133,7 +133,8 @@ class Chart extends React.Component {
       }
     }
 
-    return false;
+    // `cacheBusterProp` is jnjected by react-hot-loader
 
 Review comment:
   typo `injected`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to