kristw commented on a change in pull request #9389: Migrating unique BigNumber(/Total) controls URL: https://github.com/apache/incubator-superset/pull/9389#discussion_r398926207
########## File path: CONTRIBUTING.md ########## @@ -1016,15 +1016,6 @@ The `metric` (or equivalent) and `timeseries_limit_metric` fields are all compos The filter-box configuration references column names (via the `column` key) and optionally metric names (via the `metric` key) if sorting is defined. -### Options - -| Field | Type | Notes | -| ---------------------- | --------- | ------------------------------------ | -| `compare_lag` | _number_ | The **Comparison Period Lag** widget | -| `compare_suffix` | _string_ | The **Comparison suffix** widget | -| `show_trend_line` | _boolean_ | The **Show Trend Line** widget | -| `start_y_axis_at_zero` | _boolean_ | The **Start y-axis at 0** widget | - Review comment: I am not 100% sure about this part but seems reasonable I guess. Or you can copy the note as comment in the js file if it seems useful. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
