graceguo-supercat commented on a change in pull request #9401: [fix] dashboard
filter indicator no showing single number value
URL:
https://github.com/apache/incubator-superset/pull/9401#discussion_r399065300
##########
File path:
superset-frontend/src/dashboard/components/FilterIndicatorsContainer.jsx
##########
@@ -101,6 +101,15 @@ export default class FilterIndicatorsContainer extends
React.PureComponent {
chartId,
column: name,
});
+
+ // filter values could be single value or array of values
+ const values =
+ isNil(columns[name]) ||
+ (isDateFilter && columns[name] === 'No filter') ||
+ (Array.isArray(columns[name]) && columns[name].length === 0)
Review comment:
isEmpty(number) will return true, this caused indicator didn't show the
selected filter value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
