[GitHub] [incubator-superset] suddjian opened a new pull request #9412: Support alternative logos in css

[GitBox]

suddjian opened a new pull request #9412: Support alternative logos in css
URL: https://github.com/apache/incubator-superset/pull/9412
 
 
   ### CATEGORY
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   The css used to position the logo in the navbar doesn't work well when a 
custom logo with different dimensions is used. This changes the rule so that 
the Superset logo is in the exact same position, but other logos will also be 
centered properly.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   Before
   <img width="767" alt="Screen Shot 2020-03-28 at 8 55 41 PM" 
src="https://user-images.githubusercontent.com/1858430/77839963-cecdfc00-7136-11ea-8a3b-045bc52adca0.png";>
   
   After
   <img width="753" alt="Screen Shot 2020-03-28 at 8 55 29 PM" 
src="https://user-images.githubusercontent.com/1858430/77839966-d55c7380-7136-11ea-998f-a5aa8fcb0357.png";>
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   Look at the logo
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @mistercrunch 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org