ktmud commented on a change in pull request #9400: Build: fix hot reload for
charts
URL:
https://github.com/apache/incubator-superset/pull/9400#discussion_r399906536
##########
File path: superset-frontend/src/chart/ChartRenderer.jsx
##########
@@ -78,28 +114,37 @@ class ChartRenderer extends React.Component {
}
shouldComponentUpdate(nextProps) {
- const resultsReady =
- nextProps.queryResponse &&
- ['success', 'rendered'].indexOf(nextProps.chartStatus) > -1 &&
- !nextProps.queryResponse.error &&
- !nextProps.refreshOverlayVisible;
-
- if (resultsReady) {
- this.hasQueryResponseChange =
- nextProps.queryResponse !== this.props.queryResponse;
-
- if (
- this.hasQueryResponseChange ||
- nextProps.annotationData !== this.props.annotationData ||
- nextProps.height !== this.props.height ||
- nextProps.width !== this.props.width ||
- nextProps.triggerRender ||
- nextProps.formData.color_scheme !== this.props.formData.color_scheme
- ) {
- return true;
- }
+ // if no results loaded, don't render
+ if (
+ !nextProps.queryResponse ||
+ nextProps.queryResponse.error ||
+ nextProps.refreshOverlayVisible
+ ) {
+ return false;
+ }
+
+ this.hasQueryResponseChange =
+ this.props.queryResponse !== nextProps.queryResponse;
+
+ // current chart status
+ const chartStatus = this.props.chartStatus;
+ // `rendered` status is set right after `success` or `loading`,
+ // don't trigger rerender here (see `actions.chartRenderingSucceeded`).
+ // note that even though render is not triggered, the props will still be
+ // updated.
+ if (
+ (chartStatus === 'success' || chartStatus === 'loading') &&
+ nextProps.chartStatus === 'rendered'
+ ) {
+ return false;
+ }
+
+ // already successfully rendered, only rerender when some prop is updated
+ if (chartStatus === 'rendered' || chartStatus === 'success') {
+ return !deepEqual(this.props, nextProps, 2);
Review comment:
Never mind. Just realized all these changes are not necessary after the fix
on `src/dashboard/components/gridComponents/Chart.jsx`. My guess is this allows
module updates propagate to `ChartRenderer` such that hot loader would know
which module to update.
The diff should now be much simpler for review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
