john-bodley commented on a change in pull request #9422: Fix user impersonation
with presto
URL:
https://github.com/apache/incubator-superset/pull/9422#discussion_r400652220
##########
File path: superset/models/core.py
##########
@@ -313,6 +314,9 @@ def get_sqla_engine(
if connect_args:
params["connect_args"] = connect_args
+ if user_name and self.impersonate_user and
str(sqlalchemy_url).startswith('presto'):
Review comment:
See ^^. You should update `get_configuration_for_impersonation` to handle
this. Note given that this isn't part of the `connection` key the
`get_configuration_for_impersonation` needs be refactored to be
`get_connection_args_for_impersonation`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
