villebro opened a new pull request #9436: Add check for SSL certificate and add 
form validators
URL: https://github.com/apache/incubator-superset/pull/9436
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   PR #9396 introduced a regression which caused adding databases to fail. This 
fixes that regression and adds a form validator to give feedback if the 
certificate is invalid.
   
   ### SCREENSHOTS
   
![image](https://user-images.githubusercontent.com/33317356/78135533-b6a5f780-742a-11ea-8f61-3a04c7378749.png)
   
![image](https://user-images.githubusercontent.com/33317356/78135740-0b497280-742b-11ea-8fe3-a6015bf65855.png)
   
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: closes #9431 , closes #9434
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to