[GitHub] [incubator-superset] d-jeon opened a new issue #7903: Gamma users can create charts for the data source they don't have access

Wed, 01 Apr 2020 10:25:41 -0700 

d-jeon opened a new issue #7903: Gamma users can create charts for the data 
source they don't have access
URL: https://github.com/apache/incubator-superset/issues/7903
 
 
   Gamma users can create charts for the data source they don't have access. I 
believe it is not supposed to be like this, so if it can be confirmed as a bug, 
I would like to create PR.
   
   ### Expected results
   
   When Gamma users create a chart, they should be able to create ones only for 
the datasource they have access.
   
   ### Actual results
   
   Gamma users can see all of data sources.
   
   #### Screenshots
   
   Gamma user can see all the datasources when creating charts, event he ones 
they don't have access. This is wrong, I believe.
   
   <img width="642" alt="Charts_all" 
src="https://user-images.githubusercontent.com/29606651/61561700-e2857680-aa6f-11e9-86e8-7651a62bc0cd.png";>
   
   On the other hand, they can see only tables they are allowed to see in 
Sources -> Tables, and it is correct.
   
   <img width="1146" alt="Tables_only_flights" 
src="https://user-images.githubusercontent.com/29606651/61561696-df8a8600-aa6f-11e9-8dd3-e7c022dff4c2.png";>
   
   #### How to reproduce the bug
   
   1. Clone superset from GitHub, follow development setup as described, and 
load example data.
   2. Create a role called FlightRole and add [datasource access on 
[examples].[flights](id:11)].
   3. Create a new user and give the user Gamma and FlightRole.
   4. Login with new user.
   5. Click Charts and add a new chart.
   6. Expand 'Choose a datasource' drop box and see there are more datasources 
than allowed.
   
   ### Environment
   
   - superset version: master (ccedbea5)
   - python version: 3.6.7
   - node.js version: 11.9.0
   - npm version: 6.5.0
   
   ### Checklist
   
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [X] I have checked the superset logs for python stacktraces and included 
it here as text if there are any.
   - [X] I have reproduced the issue with at least the latest released version 
of superset.
   - [X] I have checked the issue tracker for the same issue and I haven't 
found one similar.
   -- I found two similar ones but they are old, closed, and don't have any 
response, so I open new one.
   
   ### Additional context
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to