micimize opened a new pull request #9456: Disable save button when can_add: false, can_overwrite: false URL: https://github.com/apache/incubator-superset/pull/9456 fix #8302 (except the hotkey part) I put off fixing the hotkey copy because it isn't quite accurate anyways. For instance, you can't `ctrl-s` to save on a slice unless it exists and you have overwrite permissions, and on a mac `ctrl-r` doesn't work anyhow. ### CATEGORY - [X] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY Disable chart save button when `can_add: false, can_overwrite: false` ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF before:  after:  ### TEST PLAN Configure a role such that it can view a chart but not edit/save it, then view a chart with that user. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [X] Has associated issue: #8302 - [X] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS @willbarrett maybe?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
