gaurav1999 commented on a change in pull request #7501: [WiP] Simplify
Superset's permissions
URL:
https://github.com/apache/incubator-superset/pull/7501#discussion_r402627851
##########
File path: superset/views/core.py
##########
@@ -1175,11 +1186,9 @@ def explore(self, datasource_type=None,
datasource_id=None):
return redirect(datasource.default_endpoint)
# slc perms
- slice_add_perm = security_manager.can_access("can_add",
"SliceModelView")
+ slice_add_perm = security_manager.can_access("can_write", "Slice")
Review comment:
I think on SliceModelView , you have set "class_permission_name = "Chart",
so not sure if this is supposed to be "Slice"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
