etr2460 commented on a change in pull request #9439: feat: change default time
range from sql lab to no filter
URL:
https://github.com/apache/incubator-superset/pull/9439#discussion_r403294805
##########
File path: superset-frontend/src/SqlLab/components/ExploreResultsButton.jsx
##########
@@ -139,8 +139,8 @@ class ExploreResultsButton extends React.PureComponent {
datasource: `${data.table_id}__table`,
metrics: [],
groupby: [],
+ time_range: 'No filter',
Review comment:
a bit weird that this is just plain text as opposed to `null` or something.
I don't think fixing that is required right now, but i think moving "No filter"
to a constant and using that constant it here would be reasonable. It looks
like "No filter" is used in a few other places too (tests, other components) so
maybe you could replace those your new constant too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
