rusackas commented on a change in pull request #9455: Migrating shared DeckGL
controls
URL:
https://github.com/apache/incubator-superset/pull/9455#discussion_r403377532
##########
File path: superset-frontend/src/explore/controlPanels/DeckGeojson.js
##########
@@ -43,23 +56,23 @@ export default {
},
null,
],
- ['row_limit', 'filter_nulls'],
+ ['row_limit', filterNulls],
['adhoc_filters'],
],
},
{
label: t('Map'),
controlSetRows: [
- ['mapbox_style', 'viewport'],
- // TODO ['autozoom', null],
+ ['mapbox_style', viewport],
+ // TODO [autozoom, null], // import { autozoom } from './Shared_DeckGL'
Review comment:
I don't know... the TODO is something you added a year ago. The control
exists, but I didn't add it in there to see if it works. Added functionality
seems out of scope, so I just noted where the control could be imported from.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
