ktmud opened a new pull request #9474: Enable beautiful json for dashboard 
metadata editor
URL: https://github.com/apache/incubator-superset/pull/9474
 
 
   ### CATEGORY
   
   - [ ] Bug Fix
   - [x] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   
   Reformat JSON strings in the dashboard metadata modal input so it's easier 
to edit.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   #### Before
   
![Snip20200405_58](https://user-images.githubusercontent.com/335541/78528120-7bd9f180-7793-11ea-87b7-2d4ac43cdbdd.png)
   
   #### After
   
![Snip20200405_57](https://user-images.githubusercontent.com/335541/78528123-80060f00-7793-11ea-937f-65b4041c1ff0.png)
   
   ### TEST PLAN
   
   1. Pick a random dashboard with filters
   2. Edit metadata via "Edit dashboard" -> "<Caret dropdown menu>" -> "Edit 
dashboard properties" -> "Advanced".
   
   The JSON string in the code editor should be formatted.
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   
   @graceguo-supercat @etr2460 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to