willbarrett commented on a change in pull request #9444: Implement dttm column
configuration through db extra config
URL:
https://github.com/apache/incubator-superset/pull/9444#discussion_r405159196
##########
File path: superset/connectors/sqla/models.py
##########
@@ -145,6 +147,26 @@ class TableColumn(Model, BaseColumn):
update_from_object_fields = [s for s in export_fields if s not in
("table_id",)]
export_parent = "table"
+ def get_expression(self):
+ if config["DEFAULT_DB_DTTM_ENABLED"] and not self.expression:
+ # TODO(bkyryliuk): consider serializing defaults to the DB for
better visibility.
Review comment:
Is this TODO going to be handled in the near future? If not, I'd recommend
removing it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
