ktmud commented on a change in pull request #9427: feat: Add post processing to
QueryObject
URL:
https://github.com/apache/incubator-superset/pull/9427#discussion_r405858951
##########
File path: superset/exceptions.py
##########
@@ -68,3 +68,7 @@ class CertificateException(SupersetException):
class DatabaseNotFound(SupersetException):
status = 400
+
+
+class ChartDataValidationError(SupersetException):
Review comment:
Can we name it `QueryObjectValidationError` or `QueryContextValidationError`
and assign a `status = 400`? One may confuse `ChartData` with the response
query results, and not realize it is about the request parameters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
