ktmud opened a new pull request #9495: Add explore control tabOverride at the section level URL: https://github.com/apache/incubator-superset/pull/9495 ### CATEGORY - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY https://github.com/apache/incubator-superset/pull/9440 unintentionally moved the "Options" section for Big Number chart to the "Customize" tab. This is because [ControlPanelsContainer](https://github.com/apache/incubator-superset/blob/06c4795fba48ed64e54e74eb8eb2f5a202c01fc8/superset-frontend/src/explore/components/ControlPanelsContainer.jsx#L203) used to check whether a section needs to display in the Data tab by checking whether any of the control in that section needs to run a new query when updated (`renderTrigger: false`) or has `tabOverride = data`. But it uses the config in the shared controls file, and assumes the control configs passed along are control name strings, and could be used to find the shared control config. By refactoring them into custom config, it fails to look up the shared control, hence the `renderTrigger` and `tabOverride` info. Ideally this `tabOverride` option should probably be at the section level. A bigger refactor is need to let `ControlPanelsContainer` always read from parsed control configs (instead of the control keys). This PR is just a quick fix. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF #### Before The "Options" section is displayed in the "Customize" tab.  #### After The "Options" section is displayed in the "Data" tab like before.  ### TEST PLAN - Check any big number chart with trendlines. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [x] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS @rusackas @michellethomas
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
