villebro commented on a change in pull request #9517: [Build] Add Github
workflows
URL:
https://github.com/apache/incubator-superset/pull/9517#discussion_r407342147
##########
File path: .github/workflows/superset-backend.yml
##########
@@ -0,0 +1,161 @@
+name: Backend
+
+on:
+ # only build on direct push to `master` branch
+ push:
+ branches: [ master ]
+ paths:
+ - superset/**/*.py
+ - tests/**
+ - setup.py
+ - requirements*.txt
+ # but also build on pull requests to any branch
+ # (the so-called feature branch)
+ pull_request:
+ paths:
+ - superset/**/*.py
+ - tests/**
+ - setup.py
+ - requirements*.txt
+
+jobs:
+ python-lint:
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ python-version: [3.6]
+ env:
+ PYTHON_LINT_TARGET: setup.py superset tests
+ CI: github-actions
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v2
+ - name: Cache mypy
+ uses: actions/cache@v1
+ with:
+ path: .mypy_cache
+ key: ${{ runner.os }}-mypy-${{ hashFiles('./requirements*.txt') }}
+ restore-keys: |
+ ${{ runner.os }}-mypy-
+ - name: Setup Python
+ uses: actions/setup-python@v1
+ with:
+ python-version: ${{ matrix.python-version }}
+ - name: Install dependencies
+ uses: ktmud/cached-dependencies@v1
+ - name: black
+ run: black --check $(echo $PYTHON_LINT_TARGET)
+ - name: mypy
+ run: mypy $(echo $PYTHON_LINT_TARGET)
+ - name: isort
+ run: isort --check-only --recursive $(echo $PYTHON_LINT_TARGET)
+ - name: pylint
+ # `-j 0` run Pylint in parallel
+ run: pylint -j 0 superset
+
+ python-test-postgres:
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ # run unit tests in multiple version just for fun
+ # (3.8 is not supported yet, some dependencies need an update)
+ python-version: [3.6, 3.7]
Review comment:
Really great to add `3.7` to the matrix, as it's fully functional. Once we
have `3.7` in testing we can gradually start pushing `3.8`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
