mistercrunch commented on a change in pull request #9505: (Reopened PR): Fix
broken MultiLine chart
URL:
https://github.com/apache/incubator-superset/pull/9505#discussion_r407777757
##########
File path: superset/viz.py
##########
@@ -484,8 +485,8 @@ def get_df_payload(self, query_obj=None, **kwargs):
"form_data": self.form_data,
"is_cached": self._any_cache_key is not None,
"query": self.query,
- "from_dttm": self.from_dttm,
- "to_dttm": self.to_dttm,
+ "from_dttm": self.from_dttm if hasattr(self, "from_dttm") else
None,
Review comment:
NIT: I think it may be better to init `self.from_dttm = None` in the
constructor of `BaseViz`, initializing all the attrs that may get assigned in
the lifecycle of the object there
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
