Smilebags commented on a change in pull request #8333: [WiP] docs: plug the 
Hello World plugin
URL: 
https://github.com/apache/incubator-superset/pull/8333#discussion_r407877598
 
 

 ##########
 File path: superset/viz.py
 ##########
 @@ -764,6 +764,11 @@ def query_obj(self):
         return d
 
 
+class HelloWorld(BaseViz):
 
 Review comment:
   Me too. This is a really sad limitation, if only this wasn't required, 
adding visualisations could be much simpler and more isolated.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to