codecov-io edited a comment on issue #9525: [WiP] Migrating shared NVD3 
controls to new module
URL: 
https://github.com/apache/incubator-superset/pull/9525#issuecomment-613240818
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=h1)
 Report
   > Merging 
[#9525](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/d9ebd32485b15c5cd79bcd354252610a9d33b867&el=desc)
 will **increase** coverage by `4.67%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/9525/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9525      +/-   ##
   ==========================================
   + Coverage   65.43%   70.10%   +4.67%     
   ==========================================
     Files         571      182     -389     
     Lines       29847    17477   -12370     
     Branches     3040        0    -3040     
   ==========================================
   - Hits        19529    12253    -7276     
   + Misses      10134     5224    -4910     
   + Partials      184        0     -184     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `?` | |
   | #mysql | `?` | |
   | #postgres | `70.05% <ø> (?)` | |
   | #python | `70.10% <ø> (-0.04%)` | :arrow_down: |
   | #sqlite | `69.92% <ø> (ø)` | |
   | #unittest | `70.10% <ø> (+4.67%)` | :arrow_up: |
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5)
 | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | 
[superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=)
 | `85.97% <0.00%> (-0.90%)` | :arrow_down: |
   | 
[superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==)
 | `74.94% <0.00%> (-0.23%)` | :arrow_down: |
   | 
[superset-frontend/src/utils/safeStringify.ts](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL3NhZmVTdHJpbmdpZnkudHM=)
 | | |
   | 
[...-frontend/src/explore/reducers/saveModalReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvc2F2ZU1vZGFsUmVkdWNlci5qcw==)
 | | |
   | 
[superset-frontend/src/components/RefreshLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVmcmVzaExhYmVsLmpzeA==)
 | | |
   | 
[...perset-frontend/src/middleware/loggerMiddleware.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21pZGRsZXdhcmUvbG9nZ2VyTWlkZGxld2FyZS5qcw==)
 | | |
   | 
[...nd/src/dashboard/util/getComponentWidthFromDrop.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldENvbXBvbmVudFdpZHRoRnJvbURyb3AuanM=)
 | | |
   | 
[...nd/src/dashboard/util/getDetailedComponentWidth.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERldGFpbGVkQ29tcG9uZW50V2lkdGguanM=)
 | | |
   | 
[superset-frontend/src/utils/hostNamesConfig.js](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2hvc3ROYW1lc0NvbmZpZy5qcw==)
 | | |
   | ... and [377 
more](https://codecov.io/gh/apache/incubator-superset/pull/9525/diff?src=pr&el=tree-more)
 | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=footer).
 Last update 
[08e10b4...08e10b4](https://codecov.io/gh/apache/incubator-superset/pull/9525?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to