rusackas commented on a change in pull request #9525: Migrating shared NVD3
controls to new module
URL:
https://github.com/apache/incubator-superset/pull/9525#discussion_r409299575
##########
File path: superset-frontend/src/visualizations/FilterBox/FilterBox.jsx
##########
@@ -120,8 +121,9 @@ class FilterBox extends React.Component {
getControlData(controlName) {
const { selectedValues } = this.state;
+ const controlsMap = getControlsInventory(controlName);
Review comment:
Actually, I backed this change out, to pull these controls (by key) from
`controls.jsx` as it was before. This part apparently loads control configs for
`druid_time_origin`, `granularity`, `granularity_sqla`, and `time_grain_sqla`
which are part of `controls.jsx` and are NOT part of the controls included in
`FilterBox.jsx`.
Soon, my plan (and we can talk about this if I'm not making sense here) is
to make a `GlobalControls.jsx` file with the widely-shared controls, structured
sort of like the `Shared_NVD3.js` and `Shared_DeckGL.jsx` files, so we can
import/load objects by reference rather than a string. At that point, I'll
revisit this chunk of code, thus the TODO I've added.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
